search

sebaslogen / resaca

Compose Multiplatform library to scope ViewModels to a Composable, surviving configuration changes and navigation
MIT License
392 stars 9 forks source link

Bugfix: Leak on backstack recreation #138

Closed sebaslogen closed 3 weeks ago

sebaslogen commented 3 weeks ago

Once a ViewModel is scoped in a destination that is in the backstack and a configuration change caused the Activity to be recreated, the ViewModel creationExtras was leaked (which references the NavBackStack entry which references the old Ativity)

Removed leaking references and added tests to prevent future regressions.

codecov[bot] commented 3 weeks ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella: