search

sebastiaanspeck / matchy

A Laravel application that uses the sportmonks-soccer API
MIT License
9 stars 19 forks source link

Translate injuries #4

Open sebastiaanspeck opened 5 years ago

sebastiaanspeck commented 5 years ago

Is your feature request related to a problem? Please describe. The injuries that are included with the sidelined-players are still in English.

Describe the solution you'd like I would like to have an injuries.php with the translations of the injuries for each language.

Additional context Use the injuries.php as starting point and translate the injuries to the language you are translating to.

NOTE The "knock" injury is something like a small minor injury. Here I found a forum where they discussed it.

TODO

DBX12 commented 5 years ago

I can do the German translation. Should I provide them in a injuries-de.php file or in an other way?

Edit I'm stupid enough to not recognize the directory structure, disregard the question pls ;) I'm putting it in the right location

sebastiaanspeck commented 5 years ago

Great! And name it injuries.php ;) Good luck!

sebastiaanspeck commented 5 years ago

@tribakzero Could you do this for Spanish?

sebastiaanspeck commented 5 years ago

@davidmohamedfr Could you do this for French?

sebastiaanspeck commented 5 years ago

@nipeharefa Could you do this for Indonesian? (Pay attention you change the injuries.php in the correct folder (lang/id)

tribakzero commented 5 years ago

Sorry, reviewed the list but I'm not aware of most of those injuries names in spanish.

sebastiaanspeck commented 5 years ago

You can make a start and I will find someone who can finish it.

davidmohamedfr commented 5 years ago

@davidmohamedfr Could you do this for French?

@sebastiaanspeck Yes, but I've no medical background so it will be an approximation.

sebastiaanspeck commented 5 years ago

@davidmohamedfr Could you do this for French?

@sebastiaanspeck Yes, but I've no medical background so it will be an approximation.

Thats okay as starting point.

nipeharefa commented 5 years ago

@sebastiaanspeck Okay

AangPer commented 5 years ago

I've updated almost everything in Spanish, it seems silly but "knock" I don't know if it refers just to a knock, hit, stroke or has another meaning in English

sebastiaanspeck commented 5 years ago

@sebastiaanspeck Okay

Any update?

sebastiaanspeck commented 5 years ago

I've updated almost everything in Spanish, it seems silly but "knock" I don't know if it refers just to a knock, hit, stroke or has another meaning in English

https://www.reddit.com/r/chelseafc/comments/7c6yzm/what_is_a_knock_injury/