search

sebastiaanvisser / clay

A CSS preprocessor as embedded Haskell.
Other
357 stars 73 forks source link

0.12.3 changed Property constructor #161

Closed phadej closed 6 years ago

phadej commented 6 years ago

This is breaking change, which according to PVP would require major version bump (i.e. 0.12.3 should been 0.13). Please pay attention to this in the future.

If Rule is meant to be opaque type, consider using .Internal modules, with a disclaimer that definitions are subject to change even in minor version bumps.

See https://github.com/fpco/stackage/issues/3336 and https://github.com/haskell-infra/hackage-trustees/issues/138

seanparsons commented 6 years ago

@phadej Is there something akin to Scala's MiMa that we can use to avoid breakages like this in the future?

phadej commented 6 years ago

@seanparsons good question, there is https://github.com/blitzcode/hackage-diff but I haven't used it in the past few years. It could be upgraded to use cabal new-build (or/and stack) so it don't need to play with sandboxes, then it will work nicely.

seanparsons commented 6 years ago

@phadej Hmmm, I might have a look at that this week.

seanparsons commented 6 years ago

@phadej I've pushed a 0.13.0 release and deprecated 0.12.3.

phadej commented 6 years ago

@seanparsons Thanks!