search

sebastiaanvisser / clay

A CSS preprocessor as embedded Haskell.
Other
360 stars 73 forks source link

Font error (with the font method) #163

Closed RamiroPastor closed 3 years ago

RamiroPastor commented 6 years ago

The code: 

font
  ( Required (C.rem 1.2) Nothing ["Didact Gothic", "Verdana"] [sansSerif, serif] )
  ( Optional Nothing Nothing Nothing )

Produces: 

font :    1.19999rem "Didact Gothic","Verdana" sans-serif,serif;

Which is missing a comma. Is this intentional, and related to #19 ?

turion commented 5 years ago

Agree, there should probably be a comma. Do you want to fix this and add a regression test?

github-actions[bot] commented 4 years ago

Stale issue message

github-actions[bot] commented 3 years ago

This issue has not seen any activity in a long time. If no further activity occurs, it will be closed after ten weeks.

RamiroPastor commented 3 years ago

Agree, there should probably be a comma. Do you want to fix this and add a regression test?

Maybe in the future, when i learn what is a regression test

bsima commented 3 years ago

what is a regression test

It's a test that guards against this problem happening in the future, i.e. it prevents a "regression".

turion commented 3 years ago

You could, for example, fix the issue and add exactly your example as a test. That would already be sufficient.