search

sebastiaanvisser / clay

A CSS preprocessor as embedded Haskell.
Other
360 stars 73 forks source link

[#206] Fix x # y^=z space behaviour #207

Closed vrom911 closed 4 years ago

vrom911 commented 4 years ago

Resolves #206

Thanks for your guidelines, @turion ! I made a test-case for this particular issue, and also made a quick fix. It seems not to break any existing tests, but I am not sure what you feel about these changes. Please, let me know 🙂

Oh, also, I have noticed, that test files are not listed in the .cabal file, should I add them?

turion commented 4 years ago

Oh, also, I have noticed, that test files are not listed in the .cabal file, should I add them?

Not sure yet, I'll find out!

vrom911 commented 4 years ago

Sorry for wasting your time, I assumed by your comment that the fix is needed and you don't mind to see that. However, I am not the CSS expert, so I can't say you more than a bug I found. My issue was more a question in that meaning.

Taking into consideration your comments, I see that I misunderstood you, so I am okay with closing this PR, please go ahead :+1:

turion commented 4 years ago

@vrom911 No worries, I'm happy you're contributing and we're fixing the bug :smiley: I'll look up some background on CSS to find out whether there is more to fix than this space, and come back to it.