Border module includes invalid outline properties

sebastiaanvisser / clay

A CSS preprocessor as embedded Haskell.

Other

360 stars 73 forks source link

Border module includes invalid outline properties #223

Open nsaunders opened 2 years ago

nsaunders commented 2 years ago

MDN's border-style documentation, as an example, shows "constituent properties" that allow a unique border to be applied to each side of an element. However, this does not seem to be the case for outlines: Notice, for example, how outline-style has no constituent properties listed. Indeed, my own testing suggests that outline properties can't be assigned to each side of an element independently: For example, outline-top-color yields an "unsupported property" warning in Safari:

turion commented 2 years ago

Ok, so outlineTopColor and similar functions should be removed?

nsaunders commented 2 years ago

@turion that is correct. These are the only outline functions that produce valid CSS:

outline
outlineColor
outlineStyle
outlineWidth
outlineOffset

So these should be removed:

outlineTop
outlineRight
outlineBottom
outlineLeft
outlineColor4
outlineTopColor
outlineRightColor
outlineBottomColor
outlineLeftColor
outlineStyle4
outlineTopStyle
outlineRightStyle
outlineBottomStyle
outlineLeftStyle
outlineWidth4
outlineTopWidth
outlineRightWidth
outlineBottomWidth
outlineLeftWidth

github-actions[bot] commented 3 weeks ago

This issue has not seen any activity in a long time. If no further activity occurs, it will be closed after ten weeks.

turion commented 2 weeks ago

PRs welcome to this issue :)