sebastian-heinz / Arrowgene.DragonsDogmaOnline

Server for Dragons Dogma Online
GNU Affero General Public License v3.0
150 stars 49 forks source link

Multiple stacks of the same item sometimes behave strangely #341

Closed Lowclock closed 2 weeks ago

Lowclock commented 2 months ago

Describe the bug Performing operations with multiple stacks of the same item sometimes behaves unexpectedly.

To Reproduce

  1. Go to Vicelot or any other vendor with usable items and buy a few stacks of Healing Potions, or anything else that stacks and is usable.
  2. Use, sort, discard, and perform other operations that change their quantities or positions in your in your inventory. Strange behavior seems to occur around the transition to using the last stack, but also sometimes happens before or after that.
  3. Multiple things might happen:
    • Items you use or discard get removed from a stack other than the one you selected.
    • items won't stack together.
    • Items are unable to be used or discarded, with no feedback in the server log.

Re-logging into your character fixes this behavior, at least temporarily.

Expected behavior Normally items should be used or discarded from the stack you selected, stack together into the largest possible stacks, be able to be used or discarded until depleted,

Screenshots cantuse wontstack

Additional context I experienced some other strange inventory behavior which may or may not be related, where equipping a weapon would instead equip a blank slot, with no debug output from the log. Not sure if it's related. Less common and seems harder to reproduce. Overly large gif

Conner-Schaffer commented 2 months ago

Another example -

https://github.com/sebastian-heinz/Arrowgene.DragonsDogmaOnline/assets/42190924/eef0213f-b23a-41df-b2a3-f75ac27336d9

pacampbell commented 3 weeks ago

Many of these should be addressed by PR #382

Conner-Schaffer commented 2 weeks ago

I did some testing and this appears to be entirely fixed with #382

https://github.com/user-attachments/assets/11d71eae-9d5d-4a28-9aa1-1954d42cb9d1