sebastian-heinz / Arrowgene.DragonsDogmaOnline

Server for Dragons Dogma Online
GNU Affero General Public License v3.0
161 stars 52 forks source link

Add underflow and overflow detection #365

Closed pacampbell closed 1 month ago

pacampbell commented 2 months ago

Enabled the build flag which detects underflow and overflow by default. Marked certain functions as unchecked in the networking library as they are depending on this behavior for certain operations.

Checklist:

pacampbell commented 2 months ago

Didn't add it to the database project. Seems that we store a bunch of values as negative but treat them as unsigned. The checked context doesn't seem to like that.