search

sebastian-heinz / Arrowgene.DragonsDogmaOnline

Server for Dragons Dogma Online
GNU Affero General Public License v3.0
166 stars 51 forks source link

Feat: Pre-lim Utilise Pawncraft Skills in Crafting related Handlers #435

Closed Conner-Schaffer closed 2 months ago

Conner-Schaffer commented 2 months ago

accounting for pawn levels during all types of crafting from #416.

Accurate

Crests, Dye and ChangeQuality exp and gold values for these are accurate. Bonus Course handling for BonusExp

[!NOTE]
PawnCost reduction math needs to be reverse-engineered, we have a dumped JSON from the client, but there is more to the story for the math calc. It works mostly accurately, but in some cases, be it special items or Pawn order can make the math inaccurate. GreatSuccess calc and Enhancement scaling calc is primarily madeup, and needs more investigation.

Checklist:

Conner-Schaffer commented 2 months ago

Wanted to get this wrapped up, but the cost calc will require JSONs like the Crests use. Since the cost for crests and dyes appears to scale 1:1? can probably use the same JSON. (need to verify, but out of time for today.) Might even be able to reuse the Crest JSON tbh, looks like its based on IR too.

Conner-Schaffer commented 2 months ago

Wanted to get this wrapped up, but the cost calc will require JSONs like the Crests use. Since the cost for crests and dyes appears to scale 1:1? can probably use the same JSON. (need to verify, but out of time for today.) Might even be able to reuse the Crest JSON tbh, looks like its based on IR too.

Took a quick look, Dye has the same EXP & Cost scaling as Crests. Quality doesn't.

Conner-Schaffer commented 2 months ago

the calculation for reducing costs is broken, I'll fix it when I get home later 🫡

Conner-Schaffer commented 2 months ago

The Cost reduction calculation is really strange, I don't really understand it lol

Conner-Schaffer commented 2 months ago

A little sheet.

image

Conner-Schaffer commented 2 months ago

Going to do Rusty weapons in its own PR, just seems way more sensible.

Conner-Schaffer commented 2 months ago

hmm, looks like our Pawn NTC stuff is setup wrong, EXP should show like 15 (+5) (15 being total) but ours does 10 (+5), while I do personally find this more intuitive to read, its not accurate to the rest of the game, or even the client-driven popups. Gotta fix that real quick