sebastian-heinz / Arrowgene.DragonsDogmaOnline

Server for Dragons Dogma Online
GNU Affero General Public License v3.0
162 stars 52 forks source link

Fix various crafting exp, rank & promotion-related bugs. #448

Closed Sehkah closed 4 weeks ago

Sehkah commented 4 weeks ago

Fixes

Enhancements:

Open points:

Checklist:

Sehkah commented 4 weeks ago

Does this require altering existing config json files?

Probably not, the code is pretty resilient and just ignores configs it doesn't know, so even if the public server had the intermediate state it should be fine.. Only if you actually add configs to the constructor with a provided settings object does it actually require them to be present (which I didn't in this case).

But maybe it's a good time to introduce something like a unit test for configs.

Sehkah commented 4 weeks ago

Will tackle settings enhancements in another PR.