sebastian-mollie / SyliusMolliePlugin-DO-NOT-USE-

OLD Sylius Mollie payment gateway integration. Please use the newest version. I will be closing this repo by the end of the year.
https://github.com/mollie/Sylius/releases/tag/v5.0.0
MIT License
1 stars 4 forks source link

Sylius 1.12 compatibility #289

Closed valentin-harrang closed 1 year ago

valentin-harrang commented 1 year ago

Hi,

I started a new Sylius project with 1.12 version and when I try to install SyliusMolliePlugin, I get this error:

image

My composer.json:

{
    "name": "sylius/sylius-standard",
    "type": "project",
    "description": "Starting point for projects powered by Sylius eCommerce.",
    "keywords": [
        "symfony",
        "sylius",
        "distribution",
        "ecommerce",
        "cart",
        "shopping"
    ],
    "homepage": "https://sylius.com",
    "license": "MIT",
    "authors": [
        {
            "name": "Paweł Jędrzejewski"
        },
        {
            "name": "Sylius project"
        },
        {
            "name": "Community contributions"
        }
    ],
    "require": {
        "php": "^8.0",
        "sylius/paypal-plugin": "^1.5",
        "sylius/refund-plugin": "^1.2",
        "sylius/sylius": "^1.12",
        "symfony/dotenv": "^5.4 || ^6.0",
        "symfony/flex": "^2.1",
        "symfony/runtime": "^5.4 || ^6.0"
    },
    "require-dev": {
        "behat/behat": "^3.7",
        "behat/mink-selenium2-driver": "^1.4",
        "dmore/behat-chrome-extension": "^1.3",
        "dmore/chrome-mink-driver": "^2.7",
        "friends-of-behat/mink": "^1.8",
        "friends-of-behat/mink-browserkit-driver": "^1.4",
        "friends-of-behat/mink-debug-extension": "^2.0",
        "friends-of-behat/mink-extension": "^2.4",
        "friends-of-behat/page-object-extension": "^0.3",
        "friends-of-behat/suite-settings-extension": "^1.0",
        "friends-of-behat/symfony-extension": "^2.1",
        "friends-of-behat/variadic-extension": "^1.3",
        "lchrusciel/api-test-case": "^5.0",
        "phpspec/phpspec": "^7.0",
        "phpstan/extension-installer": "^1.0",
        "phpstan/phpstan": "^1.8.4",
        "phpstan/phpstan-doctrine": "^1.3.2",
        "phpstan/phpstan-webmozart-assert": "^1.1",
        "phpunit/phpunit": "^8.5",
        "polishsymfonycommunity/symfony-mocker-container": "^1.0",
        "rector/rector": "^0.14.6",
        "stripe/stripe-php": "^6.43",
        "sylius-labs/coding-standard": "^4.0",
        "symfony/browser-kit": "^5.4 || ^6.0",
        "symfony/debug-bundle": "^5.4 || ^6.0",
        "symfony/intl": "^5.4 || ^6.0",
        "symfony/web-profiler-bundle": "^5.4 || ^6.0"
    },
    "config": {
        "preferred-install": {
            "*": "dist"
        },
        "sort-packages": true,
        "allow-plugins": {
            "symfony/flex": true,
            "dealerdirect/phpcodesniffer-composer-installer": false,
            "phpstan/extension-installer": false,
            "symfony/thanks": false,
            "symfony/runtime": true
        }
    },
    "extra": {
        "branch-alias": {
            "dev-master": "1.12-dev"
        },
        "symfony": {
            "allow-contrib": false,
            "require": "^6.0",
            "endpoint": [
                "https://api.github.com/repos/Sylius/SyliusRecipes/contents/index.json?ref=flex/main",
                "flex://defaults"
            ]
        }
    },
    "autoload": {
        "psr-4": {
            "App\\": "src/"
        }
    },
    "autoload-dev": {
        "psr-4": {
            "App\\Tests\\": "tests/"
        },
        "classmap": [
            "src/Kernel.php"
        ]
    },
    "prefer-stable": true,
    "minimum-stability": "dev",
    "scripts": {
        "post-install-cmd": [
            "@auto-scripts"
        ],
        "post-update-cmd": [
            "@auto-scripts"
        ],
        "post-create-project-cmd": [
            "@php bin/console sylius:inform-about-gus --ansi",
            "@php bin/console sylius:show-available-plugins --ansi"
        ],
        "auto-scripts": {
            "cache:clear": "symfony-cmd",
            "assets:install %PUBLIC_DIR%": "symfony-cmd"
        }
    },
    "replace": {
        "symfony/polyfill-apcu": "*",
        "symfony/polyfill-ctype": "*",
        "symfony/polyfill-iconv": "*",
        "symfony/polyfill-intl": "*",
        "symfony/polyfill-intl-grapheme": "*",
        "symfony/polyfill-intl-icu": "*",
        "symfony/polyfill-intl-idn": "*",
        "symfony/polyfill-intl-normalizer": "*",
        "symfony/polyfill-php54": "*",
        "symfony/polyfill-php55": "*",
        "symfony/polyfill-php56": "*",
        "symfony/polyfill-php70": "*",
        "symfony/polyfill-php71": "*",
        "symfony/polyfill-php72": "*",
        "symfony/polyfill-php73": "*",
        "symfony/polyfill-php74": "*",
        "symfony/polyfill-php80": "*"
    }
}

I guess the plugin is not yet compatible with version 1.12 of Sylius. Can you please make it compatible please?

rufinus commented 1 year ago

@sebastian-mollie What would you need to make it work in 1.12? I played around with the composer requirements, and after switched session service to RequestStack->getSession() calls - but this was not enough.

Coud you at least give us any feedback or a time table? I need to know if i can wait or look for a different option besides sylius.

TIA

sebastian-mollie commented 1 year ago

@rufinus not sure if you are aware but we are currently fixing existing issues in our Sylius integration. We expect to have the new version with support to the latest Sylius by the end of march more or less.

I hope that this timeline is inline with your development schedule.

michaelKaefer commented 1 year ago

@sebastian-mollie Not yet merged, could you reopen the issue so it is easier for us to follow by watching the issue?

sebastian-mollie commented 1 year ago

@michaelKaefer this is my private github, I closed it because once we have the new version I will change this project to private when it is safe to do so. I suggest you keep an eye on https://github.com/mollie/sylius.