Bug prevents editors to make multiple partial refunds

sebastian-mollie / SyliusMolliePlugin-DO-NOT-USE-

OLD Sylius Mollie payment gateway integration. Please use the newest version. I will be closing this repo by the end of the year.

MIT License

1 stars 4 forks source link

Open michaelKaefer opened 1 year ago

michaelKaefer commented 1 year ago

This seems like a bug to me:

src/Action/RefundAction.php

        if ($molliePayment->hasRefunds()) {
            return;
        }

This results in:

if an editor makes a first partial refund, the refund is successfull (because hasRefunds() returns false)
further partial refunds are refunded in Sylius (no error, everthing seems ok for the editor) but they are never sent to Mollie

I don't know the reason behind the if - can we just delete it?