search

sebastian-software / edge

The Lerna Repository for Edge Platform
Apache License 2.0
33 stars 7 forks source link

Add folders to files section as they are needed in deployment #25

Closed fastner closed 6 years ago

fastner commented 6 years ago

These files and paths are missing from ´npm pack´ to have a running version

swernerx commented 6 years ago

Thanks for the PR. This change is obvious in first place and I had some version before where it was like that. Unfortunately this is not the whole story. Same as for the "scripts" we offer right now. There has to be made some difference between what is useful for "edge-boilerplate" as is vs. using it as a app template. The current implementation is fine for the boilerplate itself, but might need tweaks when using it as an app template. We definitely have to communicate what the boilerplate is and how to use it... or offer a parallel "template" project somehow. Not sure. Closing this PR as this has to be discussed first.

fastner commented 6 years ago

Okay, so you have to explain to me what exactly the purpose of edge-boilerplate is :)

I'll move this change to edge-create then...