Closed SebastianPoetzsch closed 10 years ago
First of all, thanks for integration this! That also has been on my mind for quite a while. However, I am not a fan of integrating the source of Moritz into the Jnario repository. This has nothing to do with the license, I just want to avoid having to manually migrate every bugfix for Moritz into the Jnario repo. The best solution would be for Moritz to provide an update site (e.g. via github pages). Another possibility would be to build and integrate the plugin into the jnario update site.
Do you think about adding Moritz's plugin to a composite p2-repository among with Jnario? What can we do about it? Should we e.g. remove Moritz's plugin from the pull-request?
Please remove Moritz's plugin from the pull request. I will ask Moritz whether he can provide an update site.
Cool!
Will you arrange a composite p2-repository referencing http://meysholdt.github.io/eclipse_jdt_junit_runners/updatesite/ and your Jnario update site?
Done.
Removed Moritz plugin but couldn't run maven build because of #135
Works really nice for Feature steps and facts! Thanks! However, it seems like it doesn't work yet for Features, Scenarios and ExampleGroups. Do you plan to support these as well?
There is a snapshot build available which includes this feature.
Fixed going to spec/feature in JUnit-view by integrating https://github.com/meysholdt/eclipse_jdt_junit_runners
For this feature we used the 'eclipse_jdt_junit_runners' plugin from Moritz. We have decided to add this plugin to the Jnario source base almost unchanged to avoid unnecessary installation problems. We also decided to maintain original version number (0.1.0) keep upgrades simple.
Is it ok for you from the licence point of view?
Cheers, Sebastian, Boris