search

sebastianbenz / Jnario

Executable specifications for Java
136 stars 38 forks source link

Upgrade Should and new HTML generator #141

Closed gallandarakhneorg closed 10 years ago

gallandarakhneorg commented 10 years ago

In one of my projects, I have coded several functions that are relevant to the Should class. We should discuss the implementation details on several of them, such as should_beJnarioLink.

I also added the Must class. It is based on Should but makes assertions on the results given by Should. This class is helpful for writing specification facts.

sebastianbenz commented 10 years ago

Nice! How do you normally use the Must matchers? It would be great if you could add specs for the new methods so that the documentation is also updated:

http://jnario.org/org/jnario/spec/tests/integration/UsingShouldSpec.html

Thanks!

gallandarakhneorg commented 10 years ago

I have pushed a simplified version of my proposal. The Must class has disappeared since it is not necessary: the should statement could support the same features.

If you're agree with this proposal, I may start to code unit tests and change the documentation.

sebastianbenz commented 10 years ago

I think the new additions make sense (we could argue about the maven specific matchers). I would be happy if you update the documentation.

One thing, could you please create another pull request for the following commit, as it seems to belong to a different feature:

[maven] Add HTML generator based on examples' depths.

Thanks.

gallandarakhneorg commented 10 years ago

Close this pull request for removal. The proposed features will be proposed in two separate pull requests later.