search

sebastianbenz / Jnario

Executable specifications for Java
136 stars 38 forks source link

Fix use of args in feature steps #147

Closed timw closed 9 years ago

timw commented 9 years ago

Use of args in feature steps with arguments currently fails with a .feature file compile error - it appears that the XVariableDeclaration for args is not being generated, and FeatureLazyLinker is not being injected into the resources (I'm guessing this is what's intended).

It looks like this got broken at some point, possibly as part of 54b3d6479320da4d1f85edd39971d758eb61b66f.

This is the minimal fix I think to make args work - the use of the module overrides in org.jnario.feature.ui.internal.FeatureActivator.createInjector(String) does look a bit fragile (with multiple org.jnario.* modules declaring the same type of bindings, with the last one winning), but I'm not sure yet how to make it less so.

sebastianbenz commented 9 years ago

Thanks for spotting and fixing this one! Unfortunately, I didn't have time yet to finish the mgiration to Xtend 2.7.