search

sebastianbergmann / comparator

Provides the functionality to compare PHP values for equality.
BSD 3-Clause "New" or "Revised" License
6.99k stars 68 forks source link

Fix weak comparison between `'0'` and `false` #99

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

fixes https://github.com/sebastianbergmann/phpunit/issues/4967

mvorisek commented 2 years ago

@sebastianbergmann can you please merge this fix into 3.0 - 5.0 to fix phpunit 8.5 and 9.5?

Github Actions CI should be probably backported to 3.0 branch too, but I run the tests and they are passing.

sebastianbergmann commented 2 years ago

Thank you.

Versions 3.0.4 and 4.0.7 have been tagged, https://github.com/sebastianbergmann/phpunit/pull/4972 can be updated.