search

sebastianbergmann / dbunit

DbUnit port for PHP/PHPUnit.
https://phpunit.de/
Other
225 stars 186 forks source link

travis: PHP 7.0 nightly added #153

Closed TomasVotruba closed 9 years ago

elazar commented 9 years ago

This version should also be included in the section of allowed failures since the build is in a constant state of flux.

TomasVotruba commented 9 years ago

I guess that would make sense if the build is failing ATM.

elazar commented 9 years ago

It may not be currently failing, but that's not the only issue of consequence. Changes in the nightly PHP build could cause Travis builds to fail because of misbehaviors in PHP rather than in DbUnit. As such, until PHP 7 is stable, I believe the allowed failures section is the appropriate place for it.

TomasVotruba commented 9 years ago

I see the point. This should have been only consistent with commit to phpunit, https://github.com/sebastianbergmann/phpunit/commit/d5ecb0a2451e9c4c8b8e0e9356707371cb4f4b49

TomasVotruba commented 9 years ago

@elazar So should it really be different to other phpunit repos?

elazar commented 9 years ago

I'll defer to @sebastianbergmann if he wants to weigh in, but I suspect phpunit could have the same issue I described above.