Return type of DefaultConnection::createQueryTable should match return type of Connection::createQueryTable

sebastianbergmann / dbunit

DbUnit port for PHP/PHPUnit.

https://phpunit.de/

Other

225 stars 186 forks source link

Return type of DefaultConnection::createQueryTable should match return type of Connection::createQueryTable #216

Open yalexyu opened 5 years ago

yalexyu commented 5 years ago

As the title suggests, Connection declares createQueryTable to return an ITable whereas DefaultConnect::createQueryTable has docs to return Table.

This has tripped me up when I have strict typing enabled and the return type should have been an ITable, not a Table.