search

sebastianbergmann / diff

Diff implementation
BSD 3-Clause "New" or "Revised" License
7.58k stars 85 forks source link

Update Differ.php for IDE Helper to work #117

Closed markusramsak closed 1 year ago

markusramsak commented 1 year ago

has to be nullable for \IdeHelper\Test\TestCase\Annotator\DiffHelperTrait to work $differ = new Differ(null);

sebastianbergmann commented 1 year ago

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

markusramsak commented 1 year ago

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

why? It solves current issues with two libraries.

SpacePossum commented 1 year ago

@markusramsak likely the DiffHelperTrait needs updating and not this package, can you describe where this DiffHelperTrait comes from? (like which project, or something, I didn't find in this project nor in PHPUnit itself)

markusramsak commented 1 year ago

I think you are right that the better solution is to patch the other libraries like https://github.com/dereuromark/cakephp-ide-helper they use new Differ(null) which they should/could change to new Differ(new DiffOnlyOutputBuilder())