search

sebastianbergmann / diff

Diff implementation
BSD 3-Clause "New" or "Revised" License
7.58k stars 85 forks source link

Fix diffToArray to accept array of lines #30

Closed ThatIsGeek closed 7 years ago

ThatIsGeek commented 9 years ago

Resolves #28

GrahamCampbell commented 9 years ago

Is the encoding of DifferTest.php correct, because github thinks it's a binary file?

ThatIsGeek commented 9 years ago

The encoding is correct, but there are NUL bytes. I replaced them with \0.

steffkes commented 8 years ago

@sebastianbergmann any reasons to not merge this PR? diff as well as diffToArray suggest array|string in their doc block for $from and $to which obviously is not really the case :/

nochso commented 8 years ago

Fyi, I've worked on a fork in a different namespace. Issue was fixed here. Otherwise some refactoring and working with a Formatter interface.

(Sorry, I'm not sure about the etiquette when it comes to forking and diverting..)

sebastianbergmann commented 7 years ago

I am sorry for dropping the ball on this. This branch now has conflicts that must be resolved. Please open a new pull request. Thanks!