SpacePossum commented 7 years ago

Scoping down the classes helps keeping an easier BC promise and gives a clear signal to users what part of the package is intent to be API and what is tooling (like test) and should not be used.

(Next up will be the type hints, but I expect a lot of conflict on the current PR's so I hold on to that, after that one the line numbers can be done)

codecov-io commented 7 years ago

Codecov Report

Merging #54 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage     99.29%   99.29%           
  Complexity      108      108           
=========================================
  Files             7        7           
  Lines           282      282           
=========================================
  Hits            280      280           
  Misses            2        2

Impacted Files	Coverage Δ	Complexity Δ
...imeEfficientLongestCommonSubsequenceCalculator.php	`100% <ø> (ø)`	`10 <0> (ø)`	:arrow_down:
src/Chunk.php	`100% <ø> (ø)`	`7 <0> (ø)`	:arrow_down:
src/Parser.php	`100% <ø> (ø)`	`19 <0> (ø)`	:arrow_down:
src/Differ.php	`98.48% <ø> (ø)`	`54 <0> (ø)`	:arrow_down:
...oryEfficientLongestCommonSubsequenceCalculator.php	`100% <ø> (ø)`	`10 <0> (ø)`	:arrow_down:
src/Line.php	`100% <ø> (ø)`	`3 <0> (ø)`	:arrow_down:
src/Diff.php	`100% <ø> (ø)`	`5 <0> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 852dd59...abb966e. Read the comment docs.

sebastianbergmann commented 7 years ago

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

Please open a new pull request that only adds the final declarations. I do not use @internal, especially not for test case classes.

sebastianbergmann / diff

Mark final and internal. #54

Codecov Report