search

sebastianbergmann / diff

Diff implementation
BSD 3-Clause "New" or "Revised" License
7.58k stars 85 forks source link

Add type hinting. #56

Closed SpacePossum closed 7 years ago

SpacePossum commented 7 years ago

Not sure how you feel about keeping PHPDoc's if these contain type hint information only if the hints are now part of the method signature itself. Let me know if you want those back :)

codecov-io commented 7 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #56   +/-   ##
======================================
  Coverage         0%    0%           
  Complexity      107   107           
======================================
  Files             7     7           
  Lines           280   280           
======================================
  Misses          280   280
Impacted Files Coverage Δ Complexity Δ
src/Differ.php 0% <0%> (ø) 53 <51> (ø) :arrow_down:
src/Diff.php 0% <0%> (ø) 5 <4> (ø) :arrow_down:
src/Parser.php 0% <0%> (ø) 19 <10> (ø) :arrow_down:
src/Chunk.php 0% <0%> (ø) 7 <6> (ø) :arrow_down:
...imeEfficientLongestCommonSubsequenceCalculator.php 0% <0%> (ø) 10 <10> (ø) :arrow_down:
...oryEfficientLongestCommonSubsequenceCalculator.php 0% <0%> (ø) 10 <10> (ø) :arrow_down:
src/Line.php 0% <0%> (ø) 3 <3> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46f923c...f7c7460. Read the comment docs.

sebastianbergmann commented 7 years ago

It's good that they are gone. Would be great to have int[] or string[], for instance, though, in docblocks when array is used as the return type declaration.