Refactor private methods to match new output interface (to be made).

[SpacePossum]

This is step towards the to be made output interfaces. I opened the PR as an intermediate so reviewing is easy.

[codecov-io]

Codecov Report

Merging #59 into master will increase coverage by 99.65%. The diff coverage is 100%.

@@              Coverage Diff              @@
##             master      #59       +/-   ##
=============================================
+ Coverage         0%   99.65%   +99.65%     
- Complexity      107      111        +4     
=============================================
  Files             7        7               
  Lines           280      292       +12     
=============================================
+ Hits              0      291      +291     
+ Misses          280        1      -279

Impacted Files	Coverage Δ	Complexity Δ
src/Differ.php	99.29% <100%> (+99.29%)	57 <15> (+4)	:arrow_up:
...oryEfficientLongestCommonSubsequenceCalculator.php	100% <0%> (+100%)	10% <0%> (ø)	:arrow_down:
src/Chunk.php	100% <0%> (+100%)	7% <0%> (ø)	:arrow_down:
src/Parser.php	100% <0%> (+100%)	19% <0%> (ø)	:arrow_down:
src/Line.php	100% <0%> (+100%)	3% <0%> (ø)	:arrow_down:
...imeEfficientLongestCommonSubsequenceCalculator.php	100% <0%> (+100%)	10% <0%> (ø)	:arrow_down:
src/Diff.php	100% <0%> (+100%)	5% <0%> (ø)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7016891...3afbcaf. Read the comment docs.

[sebastianbergmann]

Is this pull request ready to be merged (and useful by itself)?

[SpacePossum]

@sebastianbergmann I've added a second commit to this PR, giving it more meaning.

This PR does roughly 3 things;

• move some internal calls and rename private methods so these match with the upcoming interface for output builders
• bug fix the code that determines common parts, as it didn't check for a trailing common part
• bug fix the diff output builder code so it does not output trailing lines if these are the same

tested as part of phpunit and the tests of phpunit itself still pass