search

sebastianbergmann / diff

Diff implementation
BSD 3-Clause "New" or "Revised" License
7.58k stars 85 forks source link

UnifiedDiffOutputBuilder - write directly to stream #62

Closed SpacePossum closed 7 years ago

SpacePossum commented 7 years ago

Writing directly into a stream prevents string copying in methods (performance gain most notable with large diff. with loads of data to output).

No logic changes, just refactor.

codecov-io commented 7 years ago

Codecov Report

Merging #62 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     99.67%   99.68%   +<.01%     
- Complexity      120      121       +1     
============================================
  Files            10       10              
  Lines           312      315       +3     
============================================
+ Hits            311      314       +3     
  Misses            1        1
Impacted Files Coverage Δ Complexity Δ
src/Output/UnifiedDiffOutputBuilder.php 100% <100%> (ø) 15 <11> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f7cdc0...0668e5a. Read the comment docs.