search

sebastianbergmann / diff

Diff implementation
BSD 3-Clause "New" or "Revised" License
7.58k stars 85 forks source link

Make Parser method statics #71

Closed soullivaneuh closed 7 years ago

soullivaneuh commented 7 years ago

The Parser class does not manage any internal property and just has two pars method.

Making them static would make more senses and would make a simpler usage:

$diffs = Parser::parse($diffsContent);
sebastianbergmann commented 7 years ago

The world is a better place for every method that is not static.

soullivaneuh commented 7 years ago

The world is a better place for every method that is not static.

Well, would you mind to elaborate a bit? :-)