search

sebastianbergmann / diff

Diff implementation
BSD 3-Clause "New" or "Revised" License
7.58k stars 85 forks source link

Fix tests to work with SF5 process package #91

Closed SpacePossum closed 4 years ago

SpacePossum commented 4 years ago

The PR fixes the tests because of the SF5 process API interface changes and updates the code style of some tests. There are no functional changes to the package itself.

fixes: https://github.com/sebastianbergmann/diff/issues/90 replaces https://github.com/sebastianbergmann/diff/pull/89

codecov[bot] commented 4 years ago

Codecov Report

Merging #91 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #91   +/-   ##
=========================================
  Coverage     99.29%   99.29%           
  Complexity      211      211           
=========================================
  Files            12       12           
  Lines           566      566           
=========================================
  Hits            562      562           
  Misses            4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81601e2...7d3539e. Read the comment docs.

SpacePossum commented 4 years ago

the tests on both SF5 https://travis-ci.org/sebastianbergmann/diff/jobs/628781123#L236 and SF4 https://travis-ci.org/sebastianbergmann/diff/jobs/628781120#L280 now pass, :tada:

sebastianbergmann commented 4 years ago

This branch has conflicts that must be resolved. Looks like I should not have merged #89. Sorry!

GrahamCampbell commented 4 years ago

Looks good, other than the travis conflict. This PR can just be merged without the changes to the travis file, I think?

sebastianbergmann commented 4 years ago

I avoid merge commits whenever I can and prefer "rebase and merge" instead. This is not possible right now so a new/updated pull request would be much appreciated.

SpacePossum commented 4 years ago

@sebastianbergmann no worries, I've rebased the PR so there are no more conflicts, tests are green as well :+1: