search

sebastianbergmann / diff

Diff implementation
BSD 3-Clause "New" or "Revised" License
7.58k stars 85 forks source link

Enhancement: Modernize build automation #95

Closed localheinz closed 4 years ago

localheinz commented 4 years ago

This PR

Fixes #93.

💁‍♂ For reference, see https://github.com/localheinz/diff/pull/5 (which currently fails because of issues reported via static analysis, and other than that, is way behind as a fork maintained for other purposes).

localheinz commented 4 years ago

@sebastianbergmann

Interestingly, running

$ vendor/bin/phpunit

on current master yields

./vendor/bin/phpunit
PHPUnit 9.0.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.13 with PCOV 1.0.6
Configuration: /Users/am/Sites/sebastianbergmann/diff/phpunit.xml

.............................................................   61 / 4156 (  1%)
...................................................SSSSSSS...  122 / 4156 (  2%)
.............................................................  183 / 4156 (  4%)
.....................................S.......................  244 / 4156 (  5%)
.....

Time: 6.64 seconds, Memory: 79.10 MB

There were 8 skipped tests:

1) SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilderIntegrationTest::testIntegrationUsingPHPFileInVendorGitApply
__OFFSET_LINE=26
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

2) SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilderIntegrationTest::testIntegrationUsingPHPFileInVendorPatch
__OFFSET_LINE=26
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

3) SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilderIntegrationTest::testIntegrationOfUnitTestCasesGitApply
__OFFSET_LINE=26
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

4) SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilderIntegrationTest::testIntegrationOfUnitTestCasesPatch
__OFFSET_LINE=26
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

5) SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilderIntegrationTest::testIntegrationDiffOutputBuilderVersusDiffCommand
__OFFSET_LINE=26
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

6) SebastianBergmann\Diff\Output\UnifiedDiffOutputBuilderIntegrationTest::testDiffWithLineNumbersPath
__OFFSET_LINE=23
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

7) SebastianBergmann\Diff\Output\UnifiedDiffOutputBuilderIntegrationTest::testDiffWithLineNumbersGitApply
__OFFSET_LINE=23
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

8) SebastianBergmann\Diff\Utils\UnifiedDiffAssertTraitIntegrationTest::testValidPatches
__OFFSET_LINE=17
__OFFSET_FILE=/Users/am/Sites/sebastianbergmann/diff/vendor/phpunit/phpunit/src/Framework/TestCase.php
Operating system matching /Linux/i is required.

OK, but incomplete, skipped, or risky tests!
Tests: 4156, Assertions: 467, Skipped: 8.

Note the total number of tests is reported as 4156.

localheinz commented 4 years ago

Thank you, @sebastianbergmann!