search

sebastianbergmann / php-code-coverage

Library that provides collection, processing, and rendering functionality for PHP code coverage information.
BSD 3-Clause "New" or "Revised" License
8.76k stars 370 forks source link

#1012 Cobertura report pulls functions from report scope, not the individual element #1013

Closed dvdoug closed 10 months ago

dvdoug commented 10 months ago

Haven't tested this myself yet, but SolovievEvgenii could you test to see if it works for you?

codecov[bot] commented 10 months ago

Codecov Report

Merging #1013 (de87a1b) into 9.2 (7134a5c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                9.2    #1013   +/-   ##
=========================================
  Coverage     84.00%   84.00%           
  Complexity     1194     1194           
=========================================
  Files            61       61           
  Lines          4275     4275           
=========================================
  Hits           3591     3591           
  Misses          684      684
Files Changed Coverage Δ
src/Report/Cobertura.php 96.55% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sebastianbergmann commented 10 months ago

Thank you, @dvdoug!

@SolovievEvgenii Can you test this, please?

bastien-phi commented 10 months ago

Good job @dvdoug ! I use cobertura reports every day and never noticed that it had issues with functions (I honestly never read them). Thanks for the fix.

After testing these changes, the report looks way better. The coverage of the functions is not duplicated anymore.

@sebastianbergmann You can wait @SolovievEvgenii to reply if you want but it looks good to me !

sebastianbergmann commented 10 months ago

@bastien-phi Thank you!