search

sebastianbergmann / phpcov

TextUI frontend for php-code-coverage
BSD 3-Clause "New" or "Revised" License
223 stars 58 forks source link

fixed issue that happens when modifying only lines not covered by code-coverage #123

Open bionda740 opened 1 year ago

bionda740 commented 1 year ago

We had an issue when modifying only the value of a constant in our source. Since the modified line of code was not covered by code-coverage, and it was the only modified line, phpcov returned the following error: 'Unable to detect executable lines that were changed. Are you sure your --path-prefix is correct?' I would propose to solve the problem by also counting the uncovered lines, and return the error only if there is actually no modified line, both covered and uncovered.

Slamdunk commented 1 year ago

@sebastianbergmann can you review this please?