sebastianbergmann / phpcov

TextUI frontend for php-code-coverage
BSD 3-Clause "New" or "Revised" License
227 stars 58 forks source link

Enhancement: Enable `no_trailing_comma_in_singleline` fixer #129

Closed localheinz closed 1 year ago

localheinz commented 1 year ago

This pull request

πŸ’β€β™‚οΈ Running

tools/php-cs-fixer fix --config=.php-cs-fixer.dist.php --diff --verbose

on current main yields

tools/php-cs-fixer fix --config=.php-cs-fixer.dist.php --diff --verbose
PHP CS Fixer 3.14.3 (b418036) Oliva by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.1.14
Loaded config default from ".php-cs-fixer.dist.php".
Using cache file ".php-cs-fixer.cache".
................                                                                                                                                                                                                                                                                                                16 / 16 (100%)
Legend: .-no changes, F-fixed, S-skipped (cached or empty file), I-invalid file syntax (file ignored), E-error

Fixed 0 of 16 files in 0.251 seconds, 16.578 MB memory used

Detected deprecations in use:
- Rule "no_trailing_comma_in_list_call" is deprecated. Use "no_trailing_comma_in_singleline" instead.
- Rule "no_trailing_comma_in_singleline_array" is deprecated. Use "no_trailing_comma_in_singleline" instead.

For reference, see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.14.3/doc/rules/basic/no_trailing_comma_in_singleline.rst.

sebastianbergmann commented 1 year ago

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have already implemented the same change as part of fa200a0656acddac4dc786f5d2ced1b8babfd2a8.