sebastianbergmann / phpcov

TextUI frontend for php-code-coverage
BSD 3-Clause "New" or "Revised" License
223 stars 58 forks source link

Text reporting missing constructor arguments #49

Closed michaldudek closed 8 years ago

michaldudek commented 8 years ago

Arguments for constructor of PHP_CodeCoverage_Report_Text were missing and they are required.

This PR fixes it by passing the required constructor arguments based on few added CLI options - and their default values based on PHPUnit values.

The added options are:

The last 3 only apply to --text report. They needed to be added as the values need to come from somewhere.

As previously submitted in https://github.com/sebastianbergmann/phpcov/pull/46

sebastianbergmann commented 8 years ago

I do not want to add additional options such as --low-upper-bound, --high-lower-bound, --show-uncovered-files, --show-only-summary, --show-colors, etc.

phpcov can read the relevant information from a PHPUnit configuration file.

michaldudek commented 8 years ago

Fair enough, now I see it's been fixed in https://github.com/sebastianbergmann/php-code-coverage/commit/c1d0d903366501c873bdb8dda64b4331bc7058ff .

webysther commented 8 years ago

@sebastianbergmann sorry but colors is interesting.

1 - --ansi option, or; 2 - --text option support --colors, or; 3 - --text option support --ansi