search

sebastianbergmann / phpcov

TextUI frontend for php-code-coverage
BSD 3-Clause "New" or "Revised" License
226 stars 58 forks source link

Fix --text in 3.0 #55

Closed lukewaite closed 7 years ago

lukewaite commented 8 years ago

I've gone ahead and opened this PR which cherry picks your fix in https://github.com/sebastianbergmann/phpcov/commit/d1cac8424ac0483fdc80cf339d6cc4c30e73bb21 into the 3.0 branch. Also updates the MergeCommand option to allow --text to be passed without an argument.

If you're willing to release as a patch release to 3.0, it would be greatly appreciated. In the event I have overlooked something, please don't hesitate to let me know and I will update/close this PR.

Fixes https://github.com/sebastianbergmann/phpcov/issues/54

lukewaite commented 8 years ago

Bump. Is it possible to get this in? If other changes are needed I will gladly make them.

sebastianbergmann commented 8 years ago

Was this not fixed by d1cac8424ac0483fdc80cf339d6cc4c30e73bb21?

lukewaite commented 8 years ago

It was fixed in d1cac84, however that was only applied to the 3.1.0 branch, and released against that.

I'm having trouble getting Laravel tests to run (issues with Facades and the global namespace) against php-code-coverage@4.0 and was hoping we could back-port this fix to the 3.0 branch for a possible patch release of 3.0.x.

ergonlogic commented 7 years ago

The --text option is indeed broken in 3.0.1. It'd be nice to get a 3.0.2 with this PR merged.

sebastianbergmann commented 7 years ago

@ergonlogic Version 3.1.0 has the fix.