search

sebastianbergmann / phpcov

TextUI frontend for php-code-coverage
BSD 3-Clause "New" or "Revised" License
223 stars 58 forks source link

Add command for checking code coverage #56

Closed scato closed 4 years ago

scato commented 8 years ago

This PR contains a command for checking code coverage. You pass the path to a .cov file and a target percentage, and it returns an exit code 1 if the coverage is insufficient.

I've replaced any version number with <unreleased>. Is that okay?

See also: #50

scato commented 8 years ago

Also, SebastianBergmann\PHPCOV\Application::doRun() didn't pass the exit code from parent::doRun(), so I had to fix that.

michaelmoussa commented 7 years ago

@sebastianbergmann any chance of this being merged & released soon, or is there any additional work that needs to be done on this PR? This is exactly what I need for another project and it'd be nice to not have to add any additional dependencies, so I'd be happy to help out if anything else is needed.

I tested this locally against the latest release (phpcov 3.1.0 and phpunit 5.6.1 at the time of this comment) and it appears to work as expected.

sebastianbergmann commented 4 years ago

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.