search

sebastianbergmann / phpcov

TextUI frontend for php-code-coverage
BSD 3-Clause "New" or "Revised" License
223 stars 58 forks source link

Add commande line option to define low and high bound #66

Closed psa-jforestier closed 4 years ago

psa-jforestier commented 7 years ago

The phpcov command line should implement options to define the lowUpperBound and highLowerBound boundaries. This settings are not accessible by the command line (only the PHPUnit interface can modify them). I propose to add command line options "--lowupperbound" and "--highlowerbound" . Theses options are used by the HTML report to classify the coverage, but the default values (50% and 90%) cant be changed by the command line interface. Thanks.

psa-jforestier commented 7 years ago

Please have a look at this PR to solve this feature request: https://github.com/sebastianbergmann/phpcov/pull/67

sebastianbergmann commented 7 years ago

I would rather not solve this through adding new commandline arguments but by reading the configuration from a phpunit.xml configuration file, if possible.

psa-jforestier commented 7 years ago

I agree with this remark. I'm working on it.

psa-jforestier commented 7 years ago

hmm seems to be difficult to get this params from a phpunit.xml file, because this XML do not have element for this settings. They are attributes of the <logging><log type="coverage-html"> element, so this two settings are members of the <log> sets. I will see if it is smart to catch the value from here. I dont know if the phpunit.xml schema is extensible to cover this feature.

sebastianbergmann commented 7 years ago

I do not understand why you want to change/extend the phpunit.xml schema. Simply take the values of the attributes from the HTML code coverage element.

psa-jforestier commented 7 years ago

Please have a look at the new PR https://github.com/sebastianbergmann/phpcov/pull/68 . It use the <logging/log type="coverage-html"> element and the the two existing attributes, as you suggested it. I was not confident with this, because to be clean I should also implement the "target" attribute (as the folder to generate the report), but it was not my goal at the begining.

psa-jforestier commented 7 years ago

Hi Sebastian. Can you please have a look at PR #68 and let me know if you can merge it ? (i work with the 3.1 version so the PR is dedicated to this version).