sebastianbergmann / phpunit-mock-objects

Mock Object library for PHPUnit
https://phpunit.de/
Other
4.97k stars 153 forks source link

Fixed PHPUnit\Framework\MockObject\Invocation usage in Matcher/* classes #391

Closed e-vyatkin closed 6 years ago

e-vyatkin commented 6 years ago

Not all classes was correctly refactored for namespace usage

codecov-io commented 6 years ago

Codecov Report

Merging #391 into master will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #391   +/-   ##
=========================================
  Coverage     72.75%   72.75%           
  Complexity      438      438           
=========================================
  Files            27       27           
  Lines          1226     1226           
=========================================
  Hits            892      892           
  Misses          334      334
Impacted Files Coverage Δ Complexity Δ
src/Matcher/AnyParameters.php 0% <0%> (ø) 2 <1> (ø) :arrow_down:
src/Matcher/InvokedCount.php 80% <100%> (ø) 9 <4> (ø) :arrow_down:
src/Matcher/MethodName.php 93.33% <100%> (ø) 5 <1> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c93faa8...de4bea1. Read the comment docs.

sebastianbergmann commented 6 years ago

Can you please provide an example test case which does not work without this patch? Thanks!

sebastianbergmann commented 6 years ago

@zhem4ag Can you please answer my question? Thanks!

e-vyatkin commented 6 years ago

Strange, I could reproduce only on single environment, but there exist conflict with phpunit installed separately in system.

Probably this PR in not needed, cause it works on other environments, where I checked.

sebastianbergmann commented 6 years ago

Thank you for your feedback. Please open a new issue and/or pull request if you are able to reproduce an issue.

sebastianbergmann commented 6 years ago

This could be the fix for #394.

misyaath commented 6 years ago

Perfect its works now Thank you so much