search

sebastianconcept / poly

Amber demo with polygons and a physics simulator
MIT License
2 stars 1 forks source link

Installation of Physics JavaScript file. #1

Closed hhzl closed 10 years ago

hhzl commented 10 years ago

Installation steps

I forked this repo and did

 git clone https://github.com/hhzl/poly

Then I did

 cd poly

and

 bower install

and 

 amber serve

Open 

  localhost:4000

An error pops up

  JavaScript exception: TypeError: window.Physics is not a function

Expectation

The Physics JavaScript file should be pulled in automatically as well. Or on a simpler level the ReadMe file should contain the installation instructions.

hhzl commented 10 years ago

Manually adding

  bower_components/PhysicsJS/dist

from https://github.com/wellcaffeinated/PhysicsJS/archive/physicsjs-v0.5.4-alpha.zip does not solve the problem.

sebastianconcept commented 10 years ago

Awesome feedback!

I’ve pushed a fix and the instructions (that are actually based in your email)

If you do the same now with the current master version it should behave

Have fun and thanks again for your input!

sebastian

o/

On Apr 22, 2014, at 12:18 PM, Hannes Hirzel notifications@github.com wrote:

Installation steps

I forked this repo and did

git clone https://github.com/hhzl/poly Then I did

cd poly and

bower install and

amber serve Open

localhost:4000 An error pops up

JavaScript exception: TypeError: window.Physics is not a function Expectation

The Physics JavaScript file is pulled in automatically as well. Or on a simpler level the ReadMe file would contain the installation instructions.

— Reply to this email directly or view it on GitHub.

hhzl commented 10 years ago

You write:

'I’ve pushed a fix and the instructions (that are actually based in your email)'

This is the advantage of markdown. The way from an email to a nicely formatted instruction file is made much smoother.

On 4/22/14, Sebastian Sastre notifications@github.com wrote:

Closed #1.

Reply to this email directly or view it on GitHub: https://github.com/sebastianconcept/poly/issues/1

sebastianconcept commented 10 years ago

On Apr 22, 2014, at 5:02 PM, Hannes Hirzel notifications@github.com wrote:

'I’ve pushed a fix and the instructions (that are actually based in your email)'

This is the advantage of markdown. The way from an email to a nicely formatted instruction file is made much smoother.

good remark

simplicityWins

sebastian

o/