search

sebastianfeldmann / phpbu

PHP Backup Utility - Creates and encrypts database and file backups, syncs your backups to other servers or cloud services and assists you monitor your backup process
https://phpbu.de
Other
1.29k stars 110 forks source link

LockTables fix #336

Closed tdutybqs closed 1 year ago

tdutybqs commented 1 year ago

Hello, I did try to to set the lockTables to false in the XML configuration file, unfortunately this does not add appropriate parameter to the mysqldump command.

i think that phpbu configuration: <option name="lockTables" value="false" /> should result in the following output: /usr/bin/mysqldump --user='foo' --password='******' --lock-tables=false instead of /usr/bin/mysqldump --user='foo' --password='******'

tdutybqs commented 1 year ago

Tests fixed

sebastianfeldmann commented 1 year ago

Hi, sorry I could not get back to you earlier.

I already fixed the issue in version 6.0.18 :)

Thanks for the feedback and the proposed solution, I did not merge the pull request because I made some more severe changes to make it work. Thanks again