search

sebastianfeldmann / phpbu

PHP Backup Utility - Creates and encrypts database and file backups, syncs your backups to other servers or cloud services and assists you monitor your backup process
https://phpbu.de
Other
1.29k stars 110 forks source link

Upgrade to `phpseclib` version 3 #352

Open getpinga opened 9 months ago

getpinga commented 9 months ago

Is there a reason why phpseclib/phpseclib 3.0 is not supported?

Can I help somehow to add support for it?

Thanks

sebastianfeldmann commented 9 months ago

No particular reason. If we don't have to make weird version if else stuff I don't see any reason to not support it.

sebastianfeldmann commented 8 months ago

phpseclib changed a lot of the API phpbu uses to do SFTP stuff.

Currently there is no way to support both out of the box because the changes are to big to handle in a couple of if else.

Either, we have to build a SFTPClient interface and write the SFTPClientPHPSecLibV2 and SFTPClientPHPSecLibV3 implementations. Then change all phpbu stuff to use the SFTPClient interface and finally write a SFTPClientFactory that creates a client depending on what dependency is loaded.

OR and that would be my preferred way kill support for everything below phpseclib v3 and update everything so it works with the latest version.