search

sebastiangreger / kirby3-commentions

A versatile comment system and integrated Webmention endpoint for Kirby 3.
MIT License
58 stars 7 forks source link

Error when calling commentions('list') in template #142

Closed hariom147 closed 2 years ago

hariom147 commented 2 years ago

Hi @sebastiangreger,

first of all thank you for this plugin. Only after doing some research can I see how much thought and effort you put into this.

I installed a clean starterkit and the v2.0-beta.4 of your plugin (following the instrucions in this repo) and get the following error when visiting the a page of a template which has <?php commentions('list') ?> in it.

Declaration of sgkirby\Commentions\Structure::set(string $id, $props) must be compatible with Kirby\Cms\Structure::set(string $id, $props): void

Stacktrace: /starterkit/site/plugins/commentions/lib/Structure.php:35

sebastiangreger commented 2 years ago

Hi thank you for identifying this issue, caused by a change introduced with the most recent 3.7.1 version of Kirby core (ref).

I just pushed a commit to the develop branch that should fix it for the v2 beta?

hariom147 commented 2 years ago

Needed to manually fix this line, too. and now it's working again. Thank you.

macx commented 1 year ago

🤔 Still not working after fixing it manually in Commention.php#126. (Kirby 3.8.3)

sebastiangreger commented 1 year ago

Hi @macx. I have not been able to formally test the plugin beyond Kirby 3.7 and it is actually going to be retired/archived in the coming days (see note below). I am however still running it on a 3.8.2 site at this moment where it works without errors.

Could you specify what is not working? Are you getting this same Declaration of sgkirby\Commentions\Structure::__set(string $id, $props) must be compatible with Kirby\Cms\Structure::__set(string $id, $props): void error?

If you are using the latest code from the develop branch (NB. not the last "released" beta version 2.0-beta.4, as the fix referred to in this thread was never released as a new version), the method call at lib/Structure.php#35 should read public function __set(string $id, $props): void (that void is missing from the 2.0-beta.4 and led to the observed error with 3.7.x). I am unable to comment on whether or what change is needed in Commention.php#126; that version check referred to should be valid for any version from 3.6.0 onwards and deals with an unrelated change in core regarding translation functionalities.

I am sorry for the inconvenience. The lack of resources to keep putting in this kind of effort to maintain the plugin up-to-date is the exact reason why I unfortunately have to give up its development – this is explained in more detail over at: #151 Sunsetting the Commentions plugin.

macx commented 1 year ago

@sebastiangreger Sad, that you end develop this plugin.

But thanks for the hint: With telling composer to pull the develop branch, it's working. Kind of. I don't get the user form displayed, just the Webmention. Any hint?

<?php commentions('form') ?>

sebastiangreger commented 1 year ago

I don't get the user form displayed, just the Webmention. Any hint?

Are comments enabled in config for the template in question? https://github.com/sebastiangreger/kirby3-commentions/tree/develop#activate-by-template

macx commented 1 year ago

Sorry for the late answer @sebastiangreger. My fault, they were not enabled.