search

sebastiangreger / kirby3-commentions

A versatile comment system and integrated Webmention endpoint for Kirby 3.
MIT License
58 stars 7 forks source link

Upload (image) field? #75

Closed mynameisfreedom closed 11 months ago

mynameisfreedom commented 4 years ago

Hi, @sebastiangreger, thank you for phenomenal plugin.

One future request: upload field. It would be great to have that in comments, so it can be used for reviews with images.

Thank you in advance.

sebastiangreger commented 4 years ago

Hi @mynameisfreedom and thank you for your kind words :)

I have some initial sketches for a possible extension of the plugin with something like "custom fields" (in addition to the fixed fields like name, e-mail, text etc.) that would allow to create individual extensions. In the plugin's very spirit of ultimate extensibility and flexibility, I believe that would be the most versatile extension.

As a matter of fact, I believe it could be possible to implement "reviews with images" already today: you could create your own custom comment form snippet, extended by a file upload field. Then use the commentions.add:after hook to retrieve the UID of the newly created comment, read out the uploaded file from $_POST (maybe even Kirby's get(), I haven't tested this) and then save the file to some custom location. Then create a customized comment list snippet where you check whether an image exists for each comment's UID and if that is the case, display it. Not sure, would this really work -- I entirely made this up -- but if you feel compelled to try it out I'd be most curious to hear about it :slightly_smiling_face: ...it is rather hacky, though, and I'd much prefer to offer a means to extend the plugin while sticking to the built-in snippets.

But thank you for the feedback and the interesting use case -- I'll keep this in mind as I (hopefully) will look at the feature roadmap at some point. I'll keep this issue floating around as a reminder and ping you when picking it up.

mynameisfreedom commented 4 years ago

Thank you, @sebastiangreger, for your quick reply.

That extension sounds excellent. :-)

I have one project where will be needed comment/review with images integration soon, and I will try to implement it with commentions.add:after hook, but I am sure I will need your help for it. At least for some help for directions. Or some premium support if you happen to be available and willing at the time.