sebastianha / angular-bootstrap-checkbox

A checkbox for AngularJS styled to fit the Twitter Bootstrap standard design
MIT License
148 stars 66 forks source link

Prefix the directive tag name #6

Open jrgleason opened 9 years ago

jrgleason commented 9 years ago

Per angular documentation...

Best Practice: In order to avoid collisions with some future standard, it's best to prefix your own directive names. For instance, if you created a <carousel> directive, it would be problematic if HTML7 introduced the same element. A two or three letter prefix (e.g. btfCarousel) works well. Similarly, do not prefix your own directives with ng or they might conflict with directives included in a future version of Angular.

this to me means the directive should be something like sb-checkbox.

sebastianha commented 9 years ago

Good point, thank you very much for the hint!

cesaralvarado9 commented 9 years ago

+1, I was going to say the exact same thing.