search

sebastianjnuwu / acode-plugins

🕳️ Plugins that are available for free for Acode
https://acode.app/user/sebastianjnuwu@gmail.com
Apache License 2.0
45 stars 7 forks source link

Need improvement in Material Icon #2

Closed bajrangCoder closed 10 months ago

bajrangCoder commented 10 months ago

Instead of loading icons from GitHub, load it locally so it will work in offline mode too. Put your icons in dist folder and scss file access like this: this.baseUrl+"youricon.svg" And make sure to include your icons in plugin.json files array.

sebastianjnuwu commented 10 months ago

Instead of loading icons from GitHub, load it locally so it will work in offline mode too. Put your icons in dist folder and scss file access like this: this.baseUrl+"youricon.svg" And make sure to include your icons in plugin.json files array.

Still awake? My idea was to leave it locally even though I couldn't import the icons in the dist folder using plugin.json: "files": ["icons/*"], "files": ["icons/*.svg"] I tried both ways I couldn't can you tell me how to do it! About this.baseUrl+"youricon.svg" Change the scss url()? I didn't understand right

bajrangCoder commented 10 months ago

Instead of loading icons from GitHub, load it locally so it will work in offline mode too. Put your icons in dist folder and scss file access like this: this.baseUrl+"youricon.svg" And make sure to include your icons in plugin.json files array.

Still awake? My idea was to leave it locally even though I couldn't import the icons in the dist folder using plugin.json: "files": ["icons/*"], "files": ["icons/*.svg"] I tried both ways I couldn't can you tell me how to do it! About this.baseUrl+"youricon.svg" Change the scss url()? I didn't understand right

You can't do like that you will need to define every icons file in plugin.json files array Like this:

files: [
  "icons/1.svg",
  "icons/2.svg",
  And so on...
]

Inside your scss replace GitHub icon url to this: this.baseUrl + "icons/1.svg"

sebastianjnuwu commented 10 months ago

Instead of loading icons from GitHub, load it locally so it will work in offline mode too. Put your icons in dist folder and scss file access like this: this.baseUrl+"youricon.svg" And make sure to include your icons in plugin.json files array.

Still awake? My idea was to leave it locally even though I couldn't import the icons in the dist folder using plugin.json: "files": ["icons/*"], "files": ["icons/*.svg"] I tried both ways I couldn't can you tell me how to do it! About this.baseUrl+"youricon.svg" Change the scss url()? I didn't understand right

You can't do like that you will need to define every icons file in plugin.json files array Like this:

files: [
  "icons/1.svg",
  "icons/2.svg",
  And so on...
]

Inside your scss replace GitHub icon url to this: this.baseUrl + "icons/1.svg"

the icons are not going to the dist folder, and the error sass with this "+" this.baseUrl + "icons/1.svg"

I can test it there to see if it works and I will be grateful I think it must be my mistake: git clone -b <branch> <url>

bajrangCoder commented 10 months ago

You can take refrence from here : https://github.com/bajrangCoder/acode-ayu-mirage-theme

sebastianjnuwu commented 10 months ago

@bajrangCoder The plugin has been fixed now there is offline availability, we added some new icons as well that acode didn't have!