search

sebastianlux / tfbuildtask-updateAssemblyInfo

Team Foundation Build (TFBuild) task for easy updating of assembly information
https://marketplace.visualstudio.com/items?itemName=sebastianlux.UpdateAssemblyInfo
MIT License
5 stars 3 forks source link

Visual Basic projects fail in version 1.1.1 #2

Closed amaijer closed 7 years ago

amaijer commented 7 years ago

Version 1.1.1 adds an '@' in front of the version string, but that is invalid code in Visual Basic.

The resulting version lines look like this: <Assembly: AssemblyVersion(@"1.0.0.0")> <Assembly: AssemblyFileVersion(@"1.0.17066.3")>

Maybe you can add a check on file extension and only add the '@' for C# files?

sebastianlux commented 7 years ago

Hi amaijer,

thank you for reporting this issue!

I did follow your suggestion and now check the file extension and do not add the @ in case of vb files. Please try out the new release to check if everything works as expected.

Sebastian

amaijer commented 7 years ago

Hi Sebastian,

Everything is working again. Thanks for fixing it so quickly.

André

From: Sebastian Lux notifications@github.com Sent: Saturday, March 11, 2017 11:52:03 AM To: sebastianlux/tfbuildtask-updateAssemblyInfo Cc: amaijer; Author Subject: Re: [sebastianlux/tfbuildtask-updateAssemblyInfo] Visual Basic projects fail in version 1.1.1 (#2)

Hi amaijer,

thank you for reporting this issue!

I did follow your suggestion and now check the file extension and do not add the @ in case of vb files. Please try out the new releasehttps://marketplace.visualstudio.com/items?itemName=sebastianlux.UpdateAssemblyInfo to check if everything works as expected.

Sebastian

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sebastianlux/tfbuildtask-updateAssemblyInfo/issues/2#issuecomment-285859293, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZDbwIVnIri6pcYNjIzfpPQj02ICeWWrks5rknzTgaJpZM4MWd-k.