search

sebastien-bouffier / Bidoo

VCV Rack plugins
GNU General Public License v3.0
125 stars 15 forks source link

fLame v2 always there... #187

Closed Petervos2018 closed 2 years ago

Petervos2018 commented 2 years ago

Hi Seb,

afbeelding

afbeelding

fLame is always shining (through)...

Greetings Peter.

sebastien-bouffier commented 2 years ago

Hi Peter, I can hardly reproduce the issue depending on the zoom level. 100% nothing, more than 200% it happens on the right click menu but not as visible as your example, just few lines are over the menu ... what is your OS ?

Petervos2018 commented 2 years ago

Windows 10 and it's only visible if you don't run any audio through it.

afbeelding

there is no problem when audio is ran through it ( as seen on the picture).

sebastien-bouffier commented 2 years ago

On my side with the dev environment it only happens if zoom is not 100%. @ 100% with or without audio there is no problem ... I dig into it

sebastien-bouffier commented 2 years ago

Hi in 2.0.2 I removed drawing when not connected, changed the way coordinates are computed and it seems to be better. Tell me.

sebastien-bouffier commented 2 years ago

Just found the real issue. When a shape has a 0 height nvgFill can produce "bleeding" outside of the path and some artifacts appear. To avoid that issue add nvgShapeAntiAlias(args.vg,false); in the drawLayer method.

sebastien-bouffier commented 2 years ago

solved in 2.0.3

Petervos2018 commented 2 years ago

Bravo, I think this solved more than only the fLAME module. Thank you 👍

sebastien-bouffier commented 2 years ago

great :)