search

sebastien / cuisine

Chef-like functionality for Fabric
Other
1.26k stars 156 forks source link

upstart_ensure always restarts #152

Closed gwillem closed 11 years ago

gwillem commented 11 years ago

Is that on purpose? Besides that, on my Ubuntu 12.10, the upstart scripts never set run.fail, whatever the outcome.

$ service mysql status; echo $? mysql start/running, process 9170 0 $ service mysql stop; echo $? mysql stop/waiting 0 $ service mysql status; echo $? mysql stop/waiting 0 $ service mysql start; echo $? mysql start/running, process 9323 0 $ service mysql start; echo $? start: Job is already running: mysql 1

So, a better strategy seems to be to just run "service start" and let the upstart scripts do the logic.

sebastien commented 11 years ago

Actually, this is a bug -- upstart_ensure should only start when the script is not running, but not stop in any case.

gcmalloc commented 11 years ago

this is fixed, can you close the bug ?

gwillem commented 11 years ago

FWIW, I've moved over to https://github.com/ansible/ansible which is more actively maintained.

Thanks Sebastien for creating and sharing your code! I've learned some Python from it ;)