Closed sebastiencs closed 4 years ago
This PR assumes that the list of candidates changes only when company-prefix changes, is this correct ?
Yes, but the selection can change, so you might have to re-render the list. But this action is amenable to optimization, if you want (IME, fully re-rendering 10 lines doesn't take a lot of time anyway).
@dgutov Thanks, yes it will replace the buffer when company-prefix
has changed. The selection is always taken into account, with and without a change in company-prefix
@sebastiencs Thanks, it feels faster now.
@kiennq Great, thanks for testing
Hi @sebastiencs , after upgrating to the latest company-box
, no completion candidate had been rendered, but only rendering a list of placeholders (empty strings), but docs and completions are working correctly.
Is it related to these changes? Thanks!
This addresses #107. Render candidates only when they become visible. Performance should be improved.
company-box-max-candidates
is now ignored andcompany-box-mode-map
removed.@kiennq Can you please try this branch and see if it's still slow.
@dgutov This PR assumes that the list of candidates changes only when
company-prefix
changes, is this correct ?