search

sebastiencs / company-box

A company front-end with icons
561 stars 64 forks source link

update company-box icons? #124

Closed stardiviner closed 3 years ago

stardiviner commented 4 years ago

The default company-box-icons-images has many duplicated icons.

I suggest to update it. @sebastiencs shared vscode-icons repo. https://github.com/microsoft/vscode-icons The background discussion here https://github.com/sebastiencs/company-box/pull/115

And here is my thought:

Thanks for pasting the link.

Can company-box display svg directly? Then no need to convert svg image to png. Does it have performance loss if using svg icon?

I checked icons in vscode-icons. I realized except some symbol- prefixed coding related icons. There are some icons maybe useful in some cases. So I choosed half of all icons.

Display vscode-icons and select icons side by side:

image

Here is a screenshot of selected icons:

image

sebastiencs commented 4 years ago

What would be the advantages of using svg files instead of png ? I might be wrong but I think displaying svg images requires some flag at compile time and external libraries, whereas png files are built in emacs. (Some users might not be able to see svg files)

Those icons looks good, I think it would be better to keep the same icons as vscode for company-box-icons-images. After a quick grep in the vscode repo, it looks like icons are determined here: https://github.com/microsoft/vscode/blob/master/src/vs/editor/common/modes.ts#L330-L359