Closed KaratasFurkan closed 2 years ago
With this PR, when company-box-right-margin
is float, company-box always start at most left of the frame. I'm working on it.
@KaratasFurkan Thanks for working on this. Did you find a way to handle float ?
I could not have a chance to investigate it, I am planning to do emacs related stuff next two days, I will probably fix this too.
Ready to review :ok_hand:
Edit: now, it moves to most left of the frame when scrolling, I did'nt notice for a week since I almost never scroll in company, I will investigate it :(
Ready to review, final this time :smile:
It turns out modify-frame-parameters function called in one more place too, I just add round to left parameter to work well with float margins.
Sorry for lateness.
Thanks for working on this @KaratasFurkan, can you please rebase your branch ?
@sebastiencs Done :+1:
Thanks @KaratasFurkan
Before:![Screenshot_20200921_165029](https://user-images.githubusercontent.com/29731420/93776938-d32e2a00-fc2c-11ea-993a-e820ef39a6f7.png)
After:![Screenshot_20200921_165149](https://user-images.githubusercontent.com/29731420/93776951-d6c1b100-fc2c-11ea-8349-6e6c17e16f8e.png)