sebastiencs / company-box

A company front-end with icons
561 stars 64 forks source link

Consider company-box-icon-right-margin when computing frame position #133

Closed KaratasFurkan closed 2 years ago

KaratasFurkan commented 3 years ago

Before: Screenshot_20200921_165029

After: Screenshot_20200921_165149

KaratasFurkan commented 3 years ago

With this PR, when company-box-right-margin is float, company-box always start at most left of the frame. I'm working on it.

sebastiencs commented 3 years ago

@KaratasFurkan Thanks for working on this. Did you find a way to handle float ?

KaratasFurkan commented 3 years ago

I could not have a chance to investigate it, I am planning to do emacs related stuff next two days, I will probably fix this too.

KaratasFurkan commented 3 years ago

Ready to review :ok_hand:

Edit: now, it moves to most left of the frame when scrolling, I did'nt notice for a week since I almost never scroll in company, I will investigate it :(

KaratasFurkan commented 3 years ago

Ready to review, final this time :smile:

It turns out modify-frame-parameters function called in one more place too, I just add round to left parameter to work well with float margins.

Sorry for lateness.

sebastiencs commented 3 years ago

Thanks for working on this @KaratasFurkan, can you please rebase your branch ?

KaratasFurkan commented 3 years ago

@sebastiencs Done :+1:

sebastiencs commented 2 years ago

Thanks @KaratasFurkan