search

sebastiencs / company-box

A company front-end with icons
561 stars 64 forks source link

lsp-mode no longer supports `company-lsp` #143

Closed jsigman closed 3 years ago

jsigman commented 3 years ago

LSP mode no longer supports company-lsp, which is the only LSP backend supported by this package. Is it impossible to make this work with company-capf? This package looks awesome

tshu-w commented 3 years ago

@jsigman as far as I know, lsp-mode has preferred to use company-capf by default for a long time.

jsigman commented 3 years ago

Right on. Do you think there's a way to make this work with company-capf?

tshu-w commented 3 years ago

I didn't quite catch you, to make what work with company-capf

jsigman commented 3 years ago

company-box?

tshu-w commented 3 years ago

company-box does not conflict with company-capf, you just need enable company-box-mode

jsigman commented 3 years ago

From the README:

For now, there are customs icons for 4 backends only: company-lsp, company-elisp, company-yasnippet and company-php.

The rich output of company-box is not enabled for company-capf, though... is this due to something fundamental in the way company-lsp works, compared to company-capf? My point is only that company-lsp is no longer an option if we want to use this package with LSP mode.

By the way, thank you for prompt answering of questions. This mode looks cool and I would love to make it work with the latest LSP versions.

nbfalcon commented 3 years ago

Rich output works for me with company-capf and lsp-completion-at-point.

MunsterPlop commented 3 years ago

I can confirm it works for me out of the box as well.